currently both the pre and post commands run in a separate thread so they do not affect the build processing.
To fail the build, the pre command would have to block until finished.
I'm not sure this is the best idea as a default since currently the pre-command could be used to execute a long running process and not affect the build processing.
I could possibly add an option to run it in the main agent thread and if that's enabled give an option to fail the build on a bad return code. Not sure if this will be confusing or not.
jonathan doklovic added a comment - 13/Aug/08 11:11 AM currently both the pre and post commands run in a separate thread so they do not affect the build processing.
To fail the build, the pre command would have to block until finished.
I'm not sure this is the best idea as a default since currently the pre-command could be used to execute a long running process and not affect the build processing.
I could possibly add an option to run it in the main agent thread and if that's enabled give an option to fail the build on a bad return code. Not sure if this will be confusing or not.
Suggestions?
Added the ability to specify if the command should run in a new thread or not.
If it does not run in a new thread, you can also specify if it should fail the build if exit code != 0
jonathan doklovic added a comment - 14/Aug/08 01:50 PM Added the ability to specify if the command should run in a new thread or not.
If it does not run in a new thread, you can also specify if it should fail the build if exit code != 0
To fail the build, the pre command would have to block until finished.
I'm not sure this is the best idea as a default since currently the pre-command could be used to execute a long running process and not affect the build processing.
I could possibly add an option to run it in the main agent thread and if that's enabled give an option to fail the build on a bad return code. Not sure if this will be confusing or not.
Suggestions?