Issue Details (XML | Word | Printable)

Key: CHK-23
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Roberto Dominguez
Reporter: James Mortimer
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Confluence Checklists Plugin

closing <table> tag in generated html is missing slash, causes formatting errors

Created: 04/Jul/07 12:50 PM   Updated: 09/Jul/07 05:15 PM
Component/s: None
Affects Version/s: 1.1
Fix Version/s: 1.1.1

Time Tracking:
Not Specified

Labels:


 Description  « Hide
Awesome plugin. solid, simple, enabling.

your html generation has a small flaw that wreck's havoc when you include a page that has a checklist inside anything that uses nested tables (i.e. a panel, div, or my homemade 'example' or 'panels' macros)

Using an 'assert' macro, I see your macro generates:

Matches? Given Bytes Expect Bytes Found
{checklist:Test|label=test} 0   416 <script type="text/javascript" src="http://mrlwiki.merck.com/s/645/1/1.1/_/download/resources/com.comalatech.checklists:checklist/checklist.js"></script> <table class="grid"> <tr> <th>Test</th> </tr> <tr> <td align="left"><a href="/display/help/Welcome+new+user" title="Welcome new user">Welcome new user</a></td> </tr> <table> <script language="javascript"> var Test = new Checklist('Test','19366216',''); </script>

Notice, the final <table> tag should be </table>.

I'd say this is 'trivial' for complexity, but 'critical' for functionality, so I ranked it as a critical bug. I hope you can do a new release with this minor bug fix quick!



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Roberto Dominguez added a comment - 06/Jul/07 01:42 PM
Fixed Typo.

James Mortimer added a comment - 09/Jul/07 05:15 PM
confirmed on my install in 1.1.1.