[#CHK-41] Sort for checklist-wiki based on Wiki-Markup and not on Wiki-Output

Confluence Checklists Plugin

Sort for checklist-wiki based on Wiki-Markup and not on Wiki-Output

Created: 14/Oct/07 09:54 AM Updated: 14/Oct/07 10:32 AM

Component/s:

None

Affects Version/s:

1.2.1, 1.3

Fix Version/s:

1.3

Time Tracking:

Original Estimate:

2 hours

Remaining Estimate:

2 hours

Time Spent:

Not Specified

File Attachments:	1. CellHandler.java (5 kB) 2. ChecklistAction.java (7 kB) 3. WikiCellHandler.java (3 kB)
Environment:	Windows XP and Linux

Labels:

sort checklist-wiki

Description

« Hide

If using checklist-wiki with scaffolding get-data the sort value is the wiki-markup and not the result output from wiki markup.

{checklist-wiki:heading=FinalDate|sorttype=S}
{get-data:readyTo|format=dd-MM-yyyy}
{checklist-wiki}

With get-data result 20.10.2007 and 18.10.2007 I would expect sort values 18.10.2007, 20.10.2007 with sorttype=S. In the current version I get GET-DATA:READY... Sort behaves undefined.

Changed method-signature in Cellhandler from:

public String makeSortValue(String value) {
        return Checklist.makeSortValue(value);
 }

to:

public String makeSortValue(Page page,String value) {
        return Checklist.makeSortValue(value);
    }

and extended handling in WikiCellHandler with method:

public String makeSortValue(Page page,String value) {
    	String v_sortValue = getChecklistManager().renderWiki(page, value);
    	return Checklist.makeSortValue(v_sortValue);
    }

Maybe a configurable version for sort handling of wiki-content is needed?

All

Comments

Work Log

Change History

FishEye

Crucible

Builds

Sort Order:

[ Permlink | « Hide ]

Roberto Dominguez added a comment - 14/Oct/07 10:32 AM

Good catch. Indeed the sort value should be rendered. I think the same problem will be there for wikiinput, although I am sure if the change on WikiCellHandler would fix it to.

The changes make sense, and I do not see a need of a "configurable version for sort handling of wiki-content', unless I am missing something.

Give me a few days to get more feedback on 1.3 and then I will incorporate the fix on 1.3.1.

Regards,

Roberto