[#CMFR-30] Group picker loads a blank window - Atlassian Developer Network JIRA

Confluence Mark For Review Plugin

Group picker loads a blank window

Created: 05/Feb/08 03:54 PM Updated: 26/Feb/08 02:24 PM

Component/s:

None

Affects Version/s:

1.3-RC3

Fix Version/s:

1.3-RC5

Time Tracking:

Not Specified

File Attachments:

None

Image Attachments:

1. ie_add_groups_1.jpg
(95 kB)

2. ie_add_groups_2.jpg
(30 kB)

3. popup.jpg
(120 kB)

Labels:

Description

« Hide

Client says:
adding groups with moderator privileges is only possible by
specifying the group names in the textfield directly, clicking on
the goup picker opens up a window which remains blank and a
Javascript error is alerted (see remaining screenshots)

All

Comments

Work Log

Change History

FishEye

Crucible

Builds

Sort Order:

[ Permlink | « Hide ]

Laura Kolker added a comment - 05/Feb/08 03:54 PM

Can't reproduce.

[ Permlink | « Hide ]

Harald Kuersten added a comment - 06/Feb/08 01:38 AM - edited

I'd like to add that it only behaves this way in IE (screenshot 1 and screenshot 2)
I just tested it on Firefox. Here, the popup does open but when, after selecting a group, I click the Add button, I get a Javascript error (see screenshot).

Between words, the localisation property

markforreview.help.instructions.delete (in Resource bundle CustomizeAction.properties)

contains a reference to a Velocity macro, which isn't executed properly (see screenshot, lower right)

[ Permlink | « Hide ]

Laura Kolker added a comment - 11/Feb/08 03:14 PM

Hi Harald,

So, I'm still having trouble reproducing this problem.
First, I'll start by describing what I'm seeing, and then I'll follow up with questions to see if we can get to the bottom of this.

I see two potentially seperate problems here.
1) described by screenshots 1 and 2
2) described by screenshot 3

I get no errors when clicking the picker icon in Firefox, for both admin and space admin screens.
I get an error similar to the one described in screenshot 3 when I run Crossover's IE for both admin and space admin screens.

Very curious.
So, at this point, I'd say the most likely culprit is environmental, probably based on the version of Confluence you're running.
Let's see if we can isolate the differences in our systems.
Currently for testing, I'm using Confluence 2.6.2
The plugin was created with Java 1.5
I'm running Firefox 2.0.0.11
on Mac OS 10.4.11 (which I anticipate is a different OS from yours, but I like to be thorough)
and the IE I run is unlikely to be the same as yours, as it's based on an emulator.
Let's try and figure out why our Firefox's aren't working the same way first.

The group picker code is mostly lifted from Confluence, so I think the first step is for you to tell me which Confluence you're running.
That way I can test against the same code base as the one you're using.

[ Permlink | « Hide ]

Daniel Sass added a comment - 13/Feb/08 04:28 AM - edited

I think this issue is related to ~~CMFR-26~~ which means the group picker isn't working as supposed to.
The problem Harald faced is because of groupnameTerm=* parameter. * means that it's searched for all groups initially which could consume some time so you'll see an empty window.
I did a fix for this problem which can be found at the ~~CMFR-26~~ comments.

[ Permlink | « Hide ]

Laura Kolker added a comment - 26/Feb/08 02:24 PM

Fixed with ~~CMFR-26~~