Issue Details (XML | Word | Printable)

Key: MARK-25
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Shannon Krebs
Reporter: Peter Teichman
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Confluence Social Bookmarking Plugin

{bookmarks:labels=foo} renders to an empty string

Created: 27/May/07 11:36 AM   Updated: 27/May/07 03:17 PM
Component/s: None
Affects Version/s: 0.5
Fix Version/s: 0.6

Time Tracking:
Not Specified

File Attachments: 1. Text File socialbookmarking-plugin-MARK-25-default-to-current-space.patch (0.6 kB)


Labels:


 Description  « Hide
Using labels= in the bookmarks macro without specifying a Confluence space renders to an empty string. According to the socialbookmarking-plugin documentation, if a space isn't specified it should default to the space of the current page.

I'm attaching a patch that makes the behavior match the documentation, so e.g. {bookmarks:labels=todo} lists all the todo bookmarks in the current space. All of the logic was already in place, but a misplaced check for a null space kept it from working.



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Peter Teichman added a comment - 27/May/07 11:38 AM
This patch fixes the behavior of {bookmarks:labels=foo} to make the macro render a bookmarks list.

Shannon Krebs added a comment - 27/May/07 03:16 PM
patch applied, only change I made was to check the ContentEntityObject was an instance of an AbstractPage before casting. (Which wasn't actually covered by the patch, but checking the change that was made I realised this bit was wrong...)