Issue Details (XML | Word | Printable)

Key: MARK-32
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Shannon Krebs
Reporter: Sarah Maddox
Votes: 2
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Confluence Social Bookmarking Plugin

Labelling for a personal space does not work when the user name contains an invalid label character

Created: 08/Jul/07 10:03 PM   Updated: 25/Jan/08 08:48 PM
Component/s: None
Affects Version/s: 1.0, 1.0.1
Fix Version/s: 1.0.9

Time Tracking:
Not Specified

Labels:


 Description  « Hide
Labelling a bookmark with a pointer to a personal space does not seem to work.

Here's a labelled bookmark:
http://extranet.atlassian.com/plugins/socialbookmarking/updatebookmark.action?bookmarkPageId=624428857&redirect=view
Bookmark exists in space DOCTEST and is labelled 'for_smaddox '
But it does not appear in my space at http://extranet.atlassian.com/spaces/space-bookmarks.action?spaceKey=~smaddox&mode=bookmarksfor

The converse does work, e.g. here's a labelled bookmark in my space:
http://extranet.atlassian.com/plugins/socialbookmarking/updatebookmark.action?bookmarkPageId=624526051&redirect=view
The above is labelled 'for_doctest' and it does appear successfully at
http://extranet.atlassian.com/spaces/space-bookmarks.action?mode=bookmarksfor&spaceKey=DOCTEST



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Shannon Krebs added a comment - 09/Jul/07 03:57 AM
I can't view the atlassian extranet confluence, but it works for me if you use ~ infront of the username:

for_~<username>

is this just a documentation problem that putting ~ isn't covered properly in the docs, or does this not work for you as well?


Kevin King added a comment - 09/Jul/07 05:43 AM
Hi Shannon,

I have this problem too. I doubt it's permissions because the problem takes place in my personal space as well. For example, when I label a bookmark for my personal space (for_~kevinrking), I get this:

The page you were trying to reach does not exist. You may want to try a search, or browse the site to find the page you were looking for.

We're running a Crowded Confluence version 2.5.3 if that helps.


Shannon Krebs added a comment - 09/Jul/07 05:53 AM
When do you get

The page you were trying to reach does not exist. You may want to try a search, or browse the site to find the page you were looking for.

is this after clicking on the links for <spacename> on the browse space page or some other time?


Kevin King added a comment - 09/Jul/07 06:21 AM
If I am looking at a bookmark, and I click a label for a personal space (e.g. for_~kevinrking or for_~otherusername), I get taken to a page that says

The page you were trying to reach does not exist. You may want to try a search, or browse the site to find the page you were looking for.

The title of the page is "Page Not Found."

If I am looking at a bookmark, and I click a label for a non-personal space (e.g. for_dev), I get taken to a collection of bookmarks for the dev space.

Conversely, if I click on the links for <spacename> on the browse space page for a personal space, I go to a page that says

There are no bookmarks to display.

Works as expected for non-personal spaces.


Sarah Maddox added a comment - 09/Jul/07 05:59 PM
Hallo Shannon

Thank you - adding the ~ in front of the username works for me i.e. if I add a label 'for_~smaddox' then I can see the bookmarks in my space, under 'Links for Sarah Maddox'.
(I thought I had tried using ~ before, but it seems not )


Shannon Krebs added a comment - 10/Jul/07 04:50 AM
Minor doco updates made as part of MARK-31 also updates to the doco page.

Kevin, in regards to the page not found error you are seeing, if you click on the for_~username label from the browse space\labels screen does it give you the same error or display all pages with that label as expected? (If it works can you see if there is any difference between the URL behind the for label link on the space labels page and the bookmark page.)


Kevin King added a comment - 10/Jul/07 05:27 AM
Same error, different URL.

For non-personal space = Key, clicking for_~kevinrking from browse space > labels goes to

http://<baseurl>/label/Key/for_~kevinrking

For non-personal space = Key, clicking for_~kevinrking from browse space > bookmarks goes to

http://<baseurl>/label/for_~kevinrking/for_~kevinrking

Both generate the same "Page Not Found" error.


Kevin King added a comment - 10/Jul/07 05:29 AM
Shoot, the second url is:

http://<baseurl>/label/~kevinrking/for_~kevinrking


Shannon Krebs added a comment - 10/Jul/07 06:19 AM
That is very strange. If other labels work I would expect these ones to work also.

If you label any other random non bookmark page with the same for_~username label do you get the same page not found error when browsing from browse space > labels ?

If you add any other labels (not for_~username) to your bookmarks to you get the same problems when clicking on the label from the bookmark at all?

Also when you add labels to your bookmarks are you adding them via the edit bookmark screen or via the normal page ajax or edit screens? (Both should work, just trying to narrow down any possible bugs.)


Kevin King added a comment - 20/Jul/07 11:56 AM
1. When I try to label for_~username for a page, I get the following:

for_~kevin.king contains invalid characters (:, ;, ,, ., , ?, &, [, ], (, ), #, ^, *, @, !).

In other words, I'm not allowed to do your first suggestion. Btw, kevin.king is my username on our system. Confluence permits me to add the label if I remove the period from the proposed label. Perhaps this is the source of the problem?

Okay, more to come. Sorry my response has taken so long.


Kevin King added a comment - 20/Jul/07 12:18 PM
2. Clicking on other labels takes you to a list of pages with the same label in that space. In other words, not a problem.

3. I've usually used the Edit Bookmark screen. That will let me add the label for_kevin.king. I just now tried the normal page AJAX way. That gives me the error I reported in #1 when I add for_kevin.king. The edit screen way gives me the same error.

I feel like we're getting close.


Shannon Krebs added a comment - 20/Jul/07 05:26 PM
updating issue summary to reflect real problem.

Paul Carruthers added a comment - 23/Jan/08 08:17 AM
Is there any movement on fixing this issue? I'd love to roll out the bookmarking plugin, but many of our users have a period (.) in their usernames, so this is really holding us back from implementing.

-pc.


Shannon Krebs added a comment - 25/Jan/08 07:29 AM
From my brief investigations there are two things that need to be done:
  • return content that matches the username labels, the label manager returns a null label when you try to retrieve a label with a special character, but it looks like if you just create a new label with the label string the content fetching methods accept it.
  • change the link provided for labels to go to the label action using the label id,