[#MARK-63] Rename 'Add Bookmark' link on Add menu to 'Bookmark' and place it in 'add-to-space' section in Confluence 2.8

Confluence Social Bookmarking Plugin

Rename 'Add Bookmark' link on Add menu to 'Bookmark' and place it in 'add-to-space' section in Confluence 2.8

Created: 12/Mar/08 06:39 PM Updated: 13/Apr/08 08:24 PM

Component/s:

User Interface

Affects Version/s:

1.1.1

Fix Version/s:

1.1.3

Security Level:

public (Anyone can view the issue)

Time Tracking:

Not Specified

Labels:

Description

« Hide

The Add Bookmark link should be renamed to just 'Bookmark' in Confluence 2.8, to be consistent with the other entries on the menu.

The new menu item should go into the 'space' section of the menu – next to Page and News – since it is adding space-level content.

To remain backwards-compatible, you can have two menu items in your plugin with a condition that uses the Confluence build number to determine which one should be shown. Remember to extend AbstractConfluenceCondition in your Condition implementation! (So you don't reintroduce ~~MARK-61~~.)

All

Comments

Work Log

Change History

FishEye

Crucible

Builds

Sort Order:

[ Permlink | « Hide ]

Shannon Krebs added a comment - 12/Mar/08 06:44 PM

I was playing with a 2.8 milestone this morning, as part of this fix I think we should make the bookmark menu item enabled by default since 2.8 now has drop down menus.

[ Permlink | « Hide ]

Matt Ryall added a comment - 12/Mar/08 06:53 PM

Shannon: agreed. This would be a good time to enable the menu item by default.

[ Permlink | « Hide ]

Shannon Krebs added a comment - 23/Mar/08 08:53 PM

New web item has been added, along with a new condition to check the Confluence build number, I'm not sure how to get the menu item in the the 'space' section of the menu though, according to the doco the "system.page.action" location does not have any sections.

[ Permlink | « Hide ]

Matt Ryall added a comment - 26/Mar/08 08:19 PM

Did you find the correct section, Shannon? As an example, the 'News' menu item can be found in plugins/content-add-sections.xml in WEB-INF/lib/confluence-2.8-m9-r2.jar, and looks like this:

<web-item key="add-news" name="Create News" section="system.content.add/space" weight="20">
    <label key="news.word" />
    <link linkId="createNewsLink">/pages/createblogpost.action?spaceKey=$generalUtil.urlEncode($helper.spaceKey)</link>
    <condition class="com.atlassian.confluence.plugin.descriptor.web.conditions.CreateContentCondition">
        <param name="content">news</param>
    </condition>
    <styleClass>add-news</styleClass>
</web-item>

[ Permlink | « Hide ]

Shannon Krebs added a comment - 26/Mar/08 08:35 PM

No I didn't get that to work, I'm sure I tried space as the section but that was an earlier milestone, will try again with m9

[ Permlink | « Hide ]

Shannon Krebs added a comment - 27/Mar/08 05:09 AM

I didn't even notice in the example above that there is a whole new location key, adding the web item to this location works fine.

The plugin dev guide needs to be updated...

[ Permlink | « Hide ]

Matt Ryall added a comment - 13/Apr/08 08:24 PM

Thanks, the plugin guide has been updated:

http://confluence.atlassian.com/display/DOC/Web+UI+Plugins